Re: libusb+librump patch

[Robert Millan]

El 15/10/15 a les 03:03, Bruno Félix Rezende Ribeiro ha escrit:
> > OTOH I think this part of your patch:
> >
> > +  #define RUMP_SYS_OPEN
> > +  #define RUMP_SYS_CLOSE
> > +  #define RUMP_SYS_IOCTL
> > +  #define RUMP_SYS_READWRITE
> >
> > is a bit dangerous. It would break any (current or future) usage of
> > open() / close() / etc in that file which is not related to USB device
> > nodes.
>
> I see.  What do you recommend?  #ifdefs for each occurrence?  Anyway,
> I'm just playing around with it.

I recommend explicit rump_sys_open(), e.g.

int fd = rump_sys_open("/dev/ugenhc", RUMP_O_RDWR);
if (fd == -1)
     error(1, rump_errno2host(errno), "rump_sys_open");

--
Robert Millan