Re: Bug#755295: Hurd term server (was: Hurd GCC ping)

[Samuel Thibault]

Thomas Schwinge, le Sun 18 Jan 2015 17:34:00 +0100, a écrit :
> (Can you now reproduce the issue?)

Yes.

> Any comments on that already?  (I don't feel like
> committing such a change without understanding it.)
> 
> --- term/ptyio.c
> +++ term/ptyio.c
> @@ -331,7 +331,7 @@ pty_io_read (struct trivfs_protid *cred,
>       }
>      }
>  
> -  if (!(termflags & TTY_OPEN) && !qsize (outputq))
> +  if (!(termflags & TTY_OPEN) && packet_mode)
>      {
>        pthread_mutex_unlock (&global_lock);
>        return EIO;

I don't see why it should be done in packet mode only. The qsize check,
on the other hand, makes sense to me, we should keep it.

Samuel