[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH hurd-dde 5/7] libmachdev: avoid malloc overhead when sending
|
From: |
Richard Braun |
|
Subject: |
Re: [PATCH hurd-dde 5/7] libmachdev: avoid malloc overhead when sending package |
|
Date: |
Wed, 26 Nov 2014 19:51:17 +0100 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Nov 26, 2014 at 06:49:40PM +0100, Samuel Thibault wrote:
> Justus Winter, le Wed 26 Nov 2014 15:22:34 +0100, a écrit :
> > * libmachdev/net.c (netif_rx_handle): Allocate message buffer on the
> > stack.
>
> Mmm, why not simply making it a struct net_rcv_msg variable?
Yes, please avoid alloca unless it really makes sense.
--
Richard Braun
- [PATCH hurd-dde 1/7] Drop superfluous files, Justus Winter, 2014/11/26
- [PATCH hurd-dde 6/7] libmachdev: fix size of `net_rcv_msg' message, Justus Winter, 2014/11/26
- [PATCH hurd-dde 7/7] libmachdev: drop static libmachdev.so hack, Justus Winter, 2014/11/26
- [PATCH hurd-dde 3/7] libmachdev: drop unused function, Justus Winter, 2014/11/26
- [PATCH hurd-dde 4/7] libmachdev: drop debugging printf, Justus Winter, 2014/11/26