Re: [PATCH 13/13] console-client: remove spurious pthread_spin_unlocks

[Samuel Thibault]

Justus Winter, le Mon 09 Dec 2013 15:16:41 +0100, a écrit :
> * console-client/trans.c (netfs_attempt_mkfile): Remove spurious
>   pthread_spin_unlock.
> (netfs_node_norefs): Likewise.

It seems completely spurious indeed.

> ---
>  console-client/trans.c |    2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/console-client/trans.c b/console-client/trans.c
> index 8219f97..00c5407 100644
> --- a/console-client/trans.c
> +++ b/console-client/trans.c
> @@ -482,7 +482,6 @@ netfs_attempt_mkfile (struct iouser *user, struct node 
> *dir,
>  
>    *np = netfs_make_node (nn);
>    pthread_mutex_lock (&(*np)->lock);
> -  pthread_spin_unlock (&netfs_node_refcnt_lock);
>  
>    return 0;
>  }
> @@ -624,7 +623,6 @@ void netfs_node_norefs (struct node *np)
>    if (np->nn->symlink_path)
>      free (np->nn->symlink_path);
>  
> -  pthread_spin_unlock (&netfs_node_refcnt_lock);
>    free (np->nn);
>    free (np);
>  }
> -- 
> 1.7.10.4
> 

-- 
Samuel
<erno> hm. I've lost a machine.. literally _lost_. it responds to ping, it 
works completely, I just can't figure out where in my apartment it is.