[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] procfs: another fix for the process file name in stat/status
|
From: |
Guillem Jover |
|
Subject: |
Re: [PATCH] procfs: another fix for the process file name in stat/status |
|
Date: |
Sun, 9 Sep 2012 01:22:43 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Sun, 2012-09-09 at 00:22:11 +0200, Samuel Thibault wrote:
> Pino Toscano, le Fri 07 Sep 2012 20:02:56 +0200, a écrit :
> > +static int args_filename_length (const char *name)
> > +{
> > + const char *p = name;
> > + while (*p != '\0' && *p != ' ')
> > + ++p;
>
> Why not using index(name, ' ') here?
index() is deprecated and it needs the NULL case handled, like strchr()
but not like strchrnul(), but better to use strcspn() anyway.
regards,
guillem