[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] Fix /proc/*/cmdline.
From: |
Samuel Thibault |
Subject: |
Re: [PATCH 1/4] Fix /proc/*/cmdline. |
Date: |
Wed, 18 Aug 2010 01:22:03 +0200 |
User-agent: |
Mutt/1.5.12-2006-07-14 |
Jeremie Koenig, le Fri 13 Aug 2010 19:05:12 +0200, a écrit :
> On Linux, /proc/NNNN/cmdline is a NUL-separated list of arguments.
> We used to truncate after the first one and add some whitespace.
You can now drop the cmdline_data variable.
> + {
> + memcpy (data, ps->args, ps->args_len);
> + *len = ps->args_len;
> + }
Mmm, isn't there a potential `data' buffer overflow? I guess *len
contains the size of the `data' buffer and should be taken into account?
Samuel
- [PATCH 1/2] Fix /proc/*/cmdline., Jeremie Koenig, 2010/08/13
- [PATCH 2/2] Implement some (global) symlinks., Jeremie Koenig, 2010/08/13
- Re: [PATCH 1/2] Fix /proc/*/cmdline., olafBuddenhagen, 2010/08/13
- [PATCH 2/4] update_pid_entries(): fix awkwardly indented uninitialized memory leak, Jeremie Koenig, 2010/08/13
- [PATCH 3/4] Set an appropriate st_mode on symlinks., Jeremie Koenig, 2010/08/13
- Re: [PATCH 3/4] Set an appropriate st_mode on symlinks., olafBuddenhagen, 2010/08/15
- Re: [PATCH 3/4] Set an appropriate st_mode on symlinks., Jeremie Koenig, 2010/08/15
- [PATCH 4/4] Implement /proc/cmdline and /proc/mounts as symlinks., Jeremie Koenig, 2010/08/13
- Re: [PATCH 4/4] Implement /proc/cmdline and /proc/mounts as symlinks., olafBuddenhagen, 2010/08/15
- Re: [PATCH 1/2] Fix /proc/*/cmdline., olafBuddenhagen, 2010/08/15
Updated procfs series, Jeremie Koenig, 2010/08/16
[PATCH 1/5] Fix /proc/*/cmdline, Jeremie Koenig, 2010/08/16