[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add support to send file descriptors over Unix sockets
|
From: |
olafBuddenhagen |
|
Subject: |
Re: [PATCH] Add support to send file descriptors over Unix sockets |
|
Date: |
Fri, 13 Aug 2010 08:45:21 +0200 |
|
User-agent: |
Mutt/1.5.20 (2009-06-14) |
Hi,
On Wed, Aug 11, 2010 at 07:02:12PM +0200, Emilio Pozuelo Monfort wrote:
> On 01/08/10 21:02, Carl Fredrik Hammar wrote:
> > Another thing that crossed my mind is what'll happen if SCM_CREDS is
> > also sent in the future? Because it also involves port, your code will
> > fail because of the j != nports test. I think this is acceptable for
> > now since the current code just fail silently anyway.
>
> Right now we don't support it so if you send it won't fail. When we add
> SCM_CREDS support, the patch that adds it can change that check (e.g.
> using an nrights and an ncreds variables), so I believe it's fine for now.
Probably deserves a comment though...
-antrik-