|
From: | Barry deFreese |
Subject: | Re: Gnumach cleanup 10 second attempt |
Date: | Mon, 21 Jul 2008 12:30:36 -0400 |
User-agent: | Thunderbird 2.0.0.14 (Windows/20080421) |
Samuel Thibault wrote:
OK I'm getting closer. I added noreturn to exception and exception_raise but I'm still getting the warning that exception_raise is returning. I thought maybe it was assert() but Asser() has __attribute__ ((noreturn)). Any idea on what else I'm missing?Barry deFreese, le Mon 21 Jul 2008 11:33:57 -0400, a écrit :Samuel Thibault wrote:OK fair enough but exception() does do a few returns, you want me to go ahead and remove those also?<snip> Indeed, but functions implicitely return at the end of it... And in that case, that's why I said to add noreturn to i386_exception and similar. exception() is one of those "similars".See the comment, they shouldn't be reached, so yes you can, but also add noreturn to the functions that are called just before, etc. ;) Samuel
Sorry to be such a pain. Thanks, Barry
[Prev in Thread] | Current Thread | [Next in Thread] |