|
From: | Matheus Morais |
Subject: | Re: Warnings removed from linux/dev/drivers/block/genhd.c |
Date: | Mon, 30 Jan 2006 21:27:38 -0200 |
At Mon, 30 Jan 2006 15:37:53 -0200,
Matheus Morais wrote:
>
> Please review, diff file in attached.
Thanks for the contribution. When submitting patches please follow
the following conventions: a description of what you are trying to
accomplish and why. In your case, you should have explained why you
think add_bsd_partition needs to be moved. You allude to it in the
subjuct but what is the warning? How does moving the code fix it?
Second, you need to include a change log. See the ChangeLog files in
the source tree for examples.
Thanks,
Neal
[Prev in Thread] | Current Thread | [Next in Thread] |