Re: GNU Mach nic patch update

[Alfred M. Szmidt]

   Alfred pointed some mistakes, so I include a revised ChangeLog
   entry.

You still haven't looked at your ChangeLog and your changes closely;
but I will fix them when I add the patch to my NIC patch.


   2004-10-25  Guillem Jover  <guillem@hadrons.org>

You haven't documented that you added quoting to all arguments, why is
this needed first of all?  I might note that this is the worst crime
one can do (not documenting a change).  Kinda like when you eat your
moms newly baked apple pie that she made for a party.

           * i386/linux/Drivers.in: Renamed winbond-840 driver to winbond_840.
           Do not include "pci-skeleton.c" in the "net" AC_DRIVER_CLASS.
           Enable the starfire, intel_gige and natsemi network drivers. Remove
           "CONFIG_" from cb_chim, starfire, sundance, winbond840, hamachi,
           natsemi, myson803 and ns820 driver declarations.

No need to document cb_chim, it is commeted out.  And there is no need
to lump all these entries together into a horrible mess of glob...

           Replace INTER_GIGE with INTEL_GIGE.

           * linux/src/include/asm-i386/cache.h: New file from linux 2.2.26.
           * linux/dev/include/linux/malloc.h: Include <asm/cache.h>.
           * linux/src/drivers/net/ns820.c: Copied to ...
           * linux/dev/drivers/net/ns820.c: ... here.
           (netsami_drv_id): Renamed to ...
           (ns820_drv_id): ... this. Fix all callers.

And please don't lump together changes like this, if you have
seperated changes, seperate them.

           * linux/src/drivers/net/intel-gige.c: Copied to ...
           * linux/dev/drivers/net/intel-gige.c: ... here.
           (skel_netdev_probe): Renamed to ...
           (igige_probe): ... this.

Ditto.

           * linux/dev/drivers/net/Space.c: Add conditional probes for natsemi,
           ns820, winbond840, hamachi, sundance, starfire, myson803 and
           intel-gige drivers.