Re: error checking in libnetfs

[Marcus Brinkmann]

On Tue, Apr 02, 2002 at 10:22:21AM -0500, Neal H Walfield wrote:
> 2002-04-02  Neal H Walfield  <neal@cs.uml.edu>
> 
>       * io-restrict-auth.c (diskfs_S_io_restrict_auth): When checking
>       the result of a function, be sure to first save the result.

This part was rewritten by Roland in 05-04.

>       Only free USER if there was an error.

This is wrong, as USER is dup'ed in diskfs_finish_protid

  if (!user)
    err = iohelp_create_simple_iouser (&cred->user, 0, 0);
  else
    err = iohelp_dup_iouser (&cred->user, user);

Thanks,
Marcus

-- 
`Rhubarb is no Egyptian god.' Debian http://www.debian.org brinkmd@debian.org
Marcus Brinkmann              GNU    http://www.gnu.org    marcus@gnu.org
Marcus.Brinkmann@ruhr-uni-bochum.de
http://www.marcus-brinkmann.de