[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [uPATCH] nicer pause-debug bootstrap
From: |
Moritz Schulte |
Subject: |
Re: [uPATCH] nicer pause-debug bootstrap |
Date: |
26 Aug 2001 10:44:44 +0200 |
User-agent: |
Gnus/5.0808 (Gnus v5.8.8) Emacs/20.7 |
Roland McGrath <roland@gnu.org> writes:
> The fflush calls should not be necessary right before getchar,
> because stdio should flush all line-buffered streams.
But mostly there isn't a newline printed.
> Are those printfs in fact not getting out? Perhaps we need a
> setlinebuf(stdout)?
In the old code there were printfs whose output didn't show up at the
right time.
> I don't really like all that hairy conditional printing.
It's not much more condotinal than before. It's conditional, because
now, there are these two cases:
Without debugging:
Hurd bootstrap server: fs exec init proc auth.
With debugging:
Hurd bootstrap server: fs
Pausing for exec... exec
Pausing for /hurd/init... init
Pausing for /hurd/proc... proc
Pausing for /hurd/auth... auth
...
> I mean, if it's a little ugly when you're debugging, so what?
I know, it's not that important. I just cleaned it a bit up, because i
like it better now. ;)
> But it seems to be it would be pretty enough just by changing the
> "Pausing..." prompts to either prepend a \n and maybe print another
> after the getchar, or by changing them to " [hit return to run %s] "
> with no \n (whichever you find prettier).
Hmm, i like the last idea, it's simple.
moritz
--
Moritz Schulte <moritz@chaosdorf.de> http://www.chaosdorf.de/moritz/
Debian/GNU supporter - http://www.debian.org/ http://www.gnu.org/
GPG fingerprint = 3A14 3923 15BE FD57 FC06 B501 0841 2D7B 6F98 4199