Re: [bug-gv] Fwd: [Bug 1071238] New: [abrt] gv: zoom_createZoom(): gv killed by SIGSEGV

[Markus Steinborn]

Markus Steinborn wrote:
> Interesting: On Fedora 20 with redhat's builds of Xaw3d and gv, I am 
> getting this crash, too. On CentOS 5 with my build of Xaw3d and gv, I 
> don't. The code crashing on Fedora 20 simply is not executed with the 
> above sequence of operations.
Finally, I got it. Observe that the resource (put it e. . in ~/.gv)

GV.gsArguments:

prevents GNU gv from crashing by aborting the zoom call before the 
crash. Removing the check for empty gs options finally fixes the bug.




commit ca3688ebdb5b3bee7126cf9636cdfc65f4684261
Author: Markus Steinborn <address@hidden>
Date:   Mon Mar 3 16:25:53 2014 +0100

    Fix crash in zoom.c

diff --git a/gv/src/zoom.c b/gv/src/zoom.c
index ccd964e..6c31645 100644
--- a/gv/src/zoom.c
+++ b/gv/src/zoom.c
@@ -104,7 +104,7 @@ zoom_createZoom(Widget w _GL_UNUSED, XtPointer 
call_data)

     BEGINMESSAGE(zoom_createZoom)

-    if (!(gv_psfile != NULL || (gv_gs_arguments && *gv_gs_arguments))) {
+    if (!gv_psfile) {
        INFMESSAGE(no file) ENDMESSAGE(zoom_createZoom)
        return;
     }



Greetings from Germany

Markus Steinborn
GNU gv maintainer