[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#73181: guix-daemon fails when invoking ‘guix authenticate’ on the Hu
From: |
Ludovic Courtès |
Subject: |
bug#73181: guix-daemon fails when invoking ‘guix authenticate’ on the Hurd |
Date: |
Tue, 05 Nov 2024 15:03:29 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Hello!
<janneke@gnu.org> skribis:
> Anyway, using this patch 0001 it seems that suppressing the warnings
> works, I no longer get
>
> "GC Warning: Repeated allocation of very large block (appr. size 112
> KiB):\n\tMay lead to memory leak and poor performance\n"
>
>
> but still get
>
> unexpected build daemon error: stoi
Damnit. Could you check with rpctrace what the daemon receives?
I wonder if I misunderstood what the root cause is.
> From 3d399e51104171ad328bea66ebdc1d6b0ac99685 Mon Sep 17 00:00:00 2001
> Message-ID:
> <3d399e51104171ad328bea66ebdc1d6b0ac99685.1730803153.git.janneke@gnu.org>
> From: Janneke Nieuwenhuizen <janneke@gnu.org>
> Date: Mon, 4 Nov 2024 14:54:55 +0100
> Subject: [PATCH 1/3] guile: Silence GC warnings on the Hurd.
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> Content-Transfer-Encoding: 8bit
> Content-Type: text/plain; charset=UTF-8
>
> This should work around <https://issues.guix.gnu.org/73181>, resurrecting
> offloading to the Hurd.
>
> * gnu/packages/aux-files/guile-launcher.c (no_warnings)[__GNU__]: New
> function.
> (main)[__GNU__]: Use it to silence libgc warnings.
>
> Co-authored-by: Ludovic Courtès <ludo@gnu.org>.
> Change-Id: I8f30732d192ce46144da4a1a081813a104a5f376
LGTM.
> #if defined __GNU__
> + /* Try to install the C locale; remain silent if it fails. */
> + setlocale (LC_ALL, "C");
This I’d rather avoid, unless we have a good understanding of why this
would help.
Thanks for working on it!
Ludo’.