[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#65720: [bug#66650] [PATCH] git: Shell out to ‘git gc’ when necessary
From: |
Simon Tournier |
Subject: |
bug#65720: [bug#66650] [PATCH] git: Shell out to ‘git gc’ when necessary. |
Date: |
Thu, 16 Nov 2023 14:24:51 +0100 |
Hi,
On Thu, 16 Nov 2023 at 13:12, Ludovic Courtès <ludo@gnu.org> wrote:
> > Well, I expect “guix gc” to take some time and I choose when. However,
> > I want “guix pull” or “guix time-machine” to be as fast as possible and
> > here some extra time is added, and I cannot control exactly when.
>
> Yes, I see. The thing is ‘maybe-run-git-gc’ is only called on the slow
> path; so for example, it’s not called on a ‘time-machine’ cache hit, but
> only on a cache miss, which is already expensive anyway.
What you mean as "only called on the slow path" is each time
'update-cached-checkout' is called, right? So, somehow when
'maybe-run-git-gc' is called appears to me "unpredictable". But
anyway. :-)
Let move it elsewhere if I am really annoyed.
Cheers,
simon