[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#65924: git searches coreutils and util-linux commands in PATH
From: |
Maxim Cournoyer |
Subject: |
bug#65924: git searches coreutils and util-linux commands in PATH |
Date: |
Mon, 09 Oct 2023 14:21:06 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Hello,
Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> Am Montag, dem 09.10.2023 um 10:21 -0400 schrieb Maxim Cournoyer:
>> Hi Liliana :-)
>>
>> Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
>>
>> > Am Samstag, dem 07.10.2023 um 23:18 -0400 schrieb Maxim Cournoyer:
>> > > It's simpler to add features on top of a minimal variant than to
>> > > remove them, and helps avoiding mistakenly changing git-minimal,
>> > > which has many dependents.
>> > >
>> > > * gnu/packages/version-control.scm (git-minimal): Move above git
>> > > and severe inheritance. Remove input label. Repatriate most
>> > > fields from...
>> > > (git): ... here. Define as package/inherit to inherit from git-
>> > > minimal.
>> > > Extend minimal values instead of overriding them whole.
>> > > ---
>> > Having done the same to Emacs recently, I fully agree with this
>> > move.
>>
>> Great; does this mean a LGTM on your side for this one? Please be
>> explicit :-).
> If you need me to reduce it to four letters, yes, LGTM.
Explicit is better than implicit. I've been thinking to document this
in our contributing section; e.g. a reviewed commit must have the 'LGTM'
from the reviewer. If a series is LGTM, it needs to be implicitly
mentioned with 'this series LGTM'. That may sound silly, but I think
it'd simplify reviewer/submitters interactions.
--
Thanks,
Maxim
- bug#65924: [PATCH core-updates 1/3] gnu: git: Remove labels and use gexps., (continued)
- bug#65924: [PATCH core-updates 3/3] gnu: git-minimal: Add coreutils and sed to PATH., Maxim Cournoyer, 2023/10/07
- bug#65924: [PATCH core-updates 2/3] gnu: git: Invert inheritance relationship., Maxim Cournoyer, 2023/10/07
- bug#65924: [PATCH core-updates 2/3] gnu: git: Invert inheritance relationship., Liliana Marie Prikler, 2023/10/08
- bug#65924: git searches coreutils and util-linux commands in PATH, Maxim Cournoyer, 2023/10/09
- bug#65924: git searches coreutils and util-linux commands in PATH, Liliana Marie Prikler, 2023/10/09
- bug#65924: git searches coreutils and util-linux commands in PATH,
Maxim Cournoyer <=
- bug#65924: git searches coreutils and util-linux commands in PATH, Liliana Marie Prikler, 2023/10/09
- bug#65924: git searches coreutils and util-linux commands in PATH, Maxim Cournoyer, 2023/10/09
- bug#65924: git searches coreutils and util-linux commands in PATH, Liliana Marie Prikler, 2023/10/09
- bug#65924: git searches coreutils and util-linux commands in PATH, Maxim Cournoyer, 2023/10/09
- bug#65924: git searches coreutils and util-linux commands in PATH, bokr, 2023/10/09
- bug#65924: git searches coreutils and util-linux commands in PATH, Liliana Marie Prikler, 2023/10/10
- bug#65924: git searches coreutils and util-linux commands in PATH, Maxim Cournoyer, 2023/10/09
bug#65924: [PATCH core-updates 2/3] gnu: git: Invert inheritance relationship., Ludovic Courtès, 2023/10/14