bug#60205: Dino lacks some icons

[Tirifto]

On úterý 20. prosince 2022 14:56:55 CET you wrote:
> Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> > Am Montag, dem 19.12.2022 um 16:14 +0000 schrieb Tirifto:
> >>   ** (dino:17647): CRITICAL **: 17:06:11.642: file /tmp/guix-build-
> >> dino-0.3.1.drv-0/dino-0.3.1/main/src/ui/main_window.vala: line 68:
> >> uncaught
> >> error: Unrecognized image file format (gdk-pixbuf-error-quark, 3)
> >>  
> >>   (dino:17647): Gtk-WARNING **: 17:06:11.676: Found an icon but could
> >> not load
> >> it. Most likely gdk-pixbuf does not provide SVG support.
> >>  
> >>   (dino:17647): Gtk-WARNING **: 17:06:11.680: Could not load a pixbuf
> >> from
> >> icon theme.
> >>   This may indicate that pixbuf loaders or the mime database could
> >> not be found.
> > 
> > These two lines appear to mark the most likely culprit.  Now, normally
> > our gdk-pixbuf packages do support svg, but there's some strings
> > attached.  Most of our GNOME related programs are tested in a GNOME
> > environment rather than a pure one, which means that things that
> > shouldn't work happen to do.  Compare the output of
> > 
> >   guix shell --pure -E DISPLAY dino librsvg adwaita-icon-theme -- dino
> > 
> > to
> > 
> >   guix shell --pure -E DISPLAY dino -- dino
> > 
> > Note that librsvg is a regular input to dino and should thus be
> > available as a pixbuf loader.  I'm not sure what exactly is wrong here
> > (perhaps dino should swap its librsvg input for gdk-pixbuf), but
> > another caveat is that on non-x86_64 systems we are forced to use a
> > pre-Rust version of librsvg, which barfs on some particular input
> > files.
> 
> Just quoting bug 48636:
> 
> I have adwaita-icon-theme and hicolor-icon-theme in my system profile,
> which I think makes some gtk stuff play nicer. I would suggest
> installing them if you don't have them. I also have
> gnome-themes-standard and gnome-themes-extra, so those may also be worth
> installing if the other things don't do the trick.
> 
> Perhaps the hicolor icons should be made a dependency so users don't
> have to figure this out on their own. I recall another package getting
> that treatment a while back.
> 
> End quote
> 
> Perhaps dino should have hicolor-icon-theme as a dependency.

Thank you both for your help! I have done some experimenting with the provided 
information. When I run the following command:

  guix shell --pure -E DISPLAY dino librsvg adwaita-icon-theme -- dino

Dino displays perfectly well, only with the Adwaita theme. I use KDE, so I 
thought installing a matching theme might allow it to match the host system. 
And indeed, after adding the packages ‘breeze’, ‘breeze-gtk’, and ‘breeze-
icons’ into my profile, Dino runs with the correct theme and icons. I assume 
it’s always a good idea to install the theme you’re using in Guix also.

The window control buttons still wouldn‘t show up until I installed ‘librsvg’ 
and incorporated it into my profile. As for ‘hicolor-icon-theme’, I don’t 
think it has had an effect on Dino; icons were still missing with only 
hicolor-icon-theme provided.

> > Hope that helps.
> > 
> > Cheers

Thank you both for your help, my issue has now been solved; although perhaps 
this ticket should remain open until it’s solved in Guix by default?

Best of wishes
// Tirifto