[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#25957: gitolite broken: created repositories keep references to /usr
From: |
Efraim Flashner |
Subject: |
bug#25957: gitolite broken: created repositories keep references to /usr/bin for hooks |
Date: |
Wed, 12 Jan 2022 20:07:37 +0200 |
On Wed, Jan 05, 2022 at 01:07:07AM +0100, zimoun wrote:
> Hi,
>
> This old bug [1] is still relevant.
>
> 1: <http://issues.guix.gnu.org/issue/25957>
>
> On Sat, 04 Mar 2017 at 13:32, ng0 <contact.ng0@cryptolab.net> wrote:
> > On 17-03-03 22:27:43, ng0 wrote:
>
> This previous…
>
> > [user@abyayala
> > /gnu/store/jw252kw9blfh1lrrib3yk4fkbj5mvdpm-gitolite-3.6.5/share/gitolite]$
> > egrep -nr "/usr/"
> > commands/svnserve:9:$svnserve ||= "/usr/bin/svnserve -r /var/svn/ -t
> > --tunnel-user=%u";
> > lib/Gitolite/Test/Tsh.pm:42:# path when cwd is [...] at
> > /usr/share/perl5/File/Temp.pm line 902".
> > lib/Gitolite/Hooks/PostUpdate.pm:62:#!/usr/bin/perl
> > lib/Gitolite/Hooks/Update.pm:158:#!/usr/bin/perl
> > lib/Gitolite/Cache.pm:127: open( REDIS, "|-", "/usr/sbin/redis-server",
> > "-" ) or die "start redis server fail
> > ed: $!";
>
> …is now…
>
> --8<---------------cut here---------------start------------->8---
> share/gitolite/lib/Gitolite/Test/Tsh.pm:42:# path when cwd is [...] at
> /usr/share/perl5/File/Temp.pm line 902".
> share/gitolite/lib/Gitolite/Cache.pm:127: open( REDIS, "|-",
> "/usr/sbin/redis-server", "-" ) or die "start redis server failed: $!";
> share/gitolite/commands/svnserve:9:$svnserve ||= "/usr/bin/svnserve -r
> /var/svn/ -t --tunnel-user=%u";
> --8<---------------cut here---------------end--------------->8---
>
> …but…
>
> > The parts I want to fix as my immediately affect every user, are in
> > the directory "lib/Gitolite/Hooks/", I have no idea about redis, but
> > I think there should be a reference to /gnu/store/ reddis and not
> > "/usr/sbin/redis-server". Different problem, related bug.. This can be
> > solved in a commit after this bug.
>
> …the package redis is not a dependency of gitolite. Therefore, the
> question is: is our Gitolite package working with Redis? Even using the
> /usr/bin one? Idem for SVN.
>
> Otherwise, I am favor to remove the 2 “problematic” references. WDYT?
Or change it to search the $PATH for the binary, so it would just be
'redis-server' or 'svnserve'
--
Efraim Flashner <efraim@flashner.co.il> רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
signature.asc
Description: PGP signature