bug#51968: Missing dependency for Xournal++

[Maxime Devos]

Daniel Meißner schreef op di 21-12-2021 om 12:43 [+0100]:
> As you can see: among others the XDG_DATA_DIRS is set which causes
> Xournal++ to find its icons.  Plus the GDK_PIXBUF_MODULE_FILE also
> resolves the problem that Xournal++ cannot recognize the file format of
> its application icon ‘pixmaps/com.github.xournalpp.xournalpp.svg’ which
> also happens with ‘guix shell --pure -f xournalpp-fix.scm -- xournalpp’.
> 
> These missing environment variables are probably because the package
> definition does not use glib-or-gtk-build-system but cmake-build-system.
> WDYT?  Maxime, can you confirm this and how should we fix this?

Now I read these two paragraphs, I think what was going wrong with the
modify-inputs adding gtk+: that modify-inputs only adds gtk+ to the
inputs, it doesn't cause gtk+ to be added to the profile whenever
xournalpp is added to the profile. For the latter, you need
propagated-inputs, but that's to be avoided due to $REASONS
(propagation conflicts, profile building performance, profile
pollution, ...).

Anyway, a wrap-program setting XDG_DATA_DIRS (and
GDK_PIXBUF_MODULE_FILE?) appropriately might be sufficient here (see
e.g. the package definition of gedit).

Adding XDG_DATA_DIRS as a native-search-path to xournalpp might work as
well, but it's a rather generic search path so I'd try to avoid that.

Greetings,
Maxime.