[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#44104: [patch] guix/scripts/publish: share signing key
From: |
Ludovic Courtès |
Subject: |
bug#44104: [patch] guix/scripts/publish: share signing key |
Date: |
Wed, 21 Oct 2020 15:11:09 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Hi,
"Amar M. Singh" <nly@disroot.org> skribis:
>>From 554416649b7400d0bbe440016c6a6a7fed0d870a Mon Sep 17 00:00:00 2001
> From: Amar Singh <nly@disroot.org>
> Date: Wed, 21 Oct 2020 02:02:02 +0530
> Subject: [PATCH] guix publish: We provide signing key. Knock yourselves out!
>
> Best in industry.
>
> Signed-off-by: Amar Singh <nly@disroot.org>
> ---
> guix/scripts/publish.scm | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)
Great idea! Some comments:
> +++ b/guix/scripts/publish.scm
> @@ -1,5 +1,6 @@
> ;;; GNU Guix --- Functional package management for GNU
> ;;; Copyright © 2015 David Thompson <davet@gnu.org>
> +;;; Copyright (C) 2020 by Amar M. Singh <nly@disroot.org>
> ;;; Copyright © 2015, 2016, 2017, 2018, 2019, 2020 Ludovic Courtès
> <ludo@gnu.org>
Please use the same format as the other lines.
> +(define (render-signing-key)
> + "Render signing key."
> + (let ((file "/etc/guix/signing-key.pub"))
> + (values `((content-type . (text/plain (charset . "UTF-8")))
> + (x-raw-file . ,file))
> + file)))
Use ‘%public-key-file’ (from (guix pki)) instead of ‘file’ here.
It would be great if you could add a test in ‘tests/publish.scm’ that
ensures GET /singing-key.pub returns 200 (you can use the
“/nix-cache-info” as a starting point and we can chat on IRC if you need
guidance.)
Bonus points if you can provide a commit log that follows our
conventions:
https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html
:-)
Could you send an updated patch?
Thanks,
Ludo’.