[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#42702: catch2 build failure on ARM
From: |
Danny Milosavljevic |
Subject: |
bug#42702: catch2 build failure on ARM |
Date: |
Tue, 4 Aug 2020 01:09:28 +0200 |
Hi Maxim,
On Mon, 03 Aug 2020 14:22:21 -0400
maxim.cournoyer@gmail.com wrote:
> } else if ('\0' <= value && value < ' ') {
> ~~~~~^~~~~~~~
I think that this tries to find non-printable characters, so those with ASCII
codes 0 < value < 32 and 128 < value < 255. But char is unsigned on ARM, so
it won't do that with the code above. Therefore, this IS an error and treating
it as a warning would be very, very, bad.
pgpuIChF_ATDa.pgp
Description: OpenPGP digital signature