bug#41498: sed fails to build on kernels with selinux

[Chris Marusich]

Hi,

I noticed that sed fails to build on my Fedora machine, but it builds
successfully on Guix System.  The error is:

--8<---------------cut here---------------start------------->8---
ERROR: testsuite/inplace-selinux
================================

inplace-selinux.sh: set-up failure: CONFIG_HEADER not defined
ERROR testsuite/inplace-selinux.sh (exit status: 99)
--8<---------------cut here---------------end--------------->8---

It appears related to this issue:

https://lists.gnu.org/archive/html/bug-sed/2019-06/msg00022.html

"This error comes from 'init.cfg' in the 'require_selinux_' function.
It happens when the system supports SELinux (based on
/proc/filesystems), but during the './configure' step, somehow the
generated Makefile did not contain a 'CONFIG_HEADER = config.h'
statement (very strange)."

Indeed, /proc/filesystems within the Guix sandbox on my Fedora system
looks like this:

--8<---------------cut here---------------start------------->8---
nodev   sysfs
nodev   tmpfs
nodev   bdev
nodev   proc
nodev   cgroup
nodev   cgroup2
nodev   cpuset
nodev   devtmpfs
nodev   configfs
nodev   debugfs
nodev   tracefs
nodev   securityfs
nodev   sockfs
nodev   bpf
nodev   pipefs
nodev   ramfs
nodev   hugetlbfs
nodev   devpts
        ext3
        ext2
        ext4
nodev   autofs
nodev   mqueue
nodev   selinuxfs
nodev   pstore
        fuseblk
nodev   fuse
nodev   fusectl
nodev   rpc_pipefs
        iso9660
--8<---------------cut here---------------end--------------->8---

However, on a vanilla Guix System (gnu/system/examples/vm-image.tmpl) it
looks like this:

--8<---------------cut here---------------start------------->8---
nodev   sysfs
nodev   tmpfs
nodev   bdev
nodev   proc
nodev   cgroup
nodev   cgroup2
nodev   cpuset
nodev   devtmpfs
nodev   debugfs
nodev   tracefs
nodev   securityfs
nodev   sockfs
nodev   bpf
nodev   pipefs
nodev   ramfs
nodev   hugetlbfs
nodev   devpts
        ext3
        ext2
        ext4
        vfat
nodev   ecryptfs
nodev   mqueue
nodev   pstore
nodev   9p
--8<---------------cut here---------------end--------------->8---

Note that "selinuxfs" is present in the Fedora case, but missing in the
Guix System case.  It seems very likely that this is causing the
failure.  We probably need to modify something in the sed build logic to
make it succeed even when "selinuxfs" is present.

-- 
Chris

signature.asc
Description: PGP signature