bug#41051: [guix-1.1.0] guix system failed

[Diego Nicola Barbato]

Hi,

wensheng xie <address@hidden> writes:

> Hi, Marius:
>
> The problem is not reproduced after I did another 'guix pull'. I attached the 
> information:
>
> 1.
> root@guix ~# guix describe
> Generation 4 May 04 2020 06:21:35 (current)
>   guix c563f88
>     repository URL: https://git.savannah.gnu.org/git/guix.git
>     branch: master
>     commit: c563f8887db23241922fabf62a4da5d1526a644f
>
> 2. config.scm is attached.
>
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> From: Marius Bakke
> Sent: Sunday, May 3, 2020 11:16 PM
> To: wensheng xie; address@hidden
> Subject: Re: bug#41051: [guix-1.1.0] guix system failed 
>
> Thanks for the report!
>
> wensheng xie <address@hidden> writes:
>
>> The error:
>>
>> root@guix ~# guix system reconfigure /etc/config.scm
>> The following derivation will be built:
>>    /gnu/store/g26kkrfd49y5wcz57x0xgkh97w997kmb-grub.cfg.drv
>> building /gnu/store/g26kkrfd49y5wcz57x0xgkh97w997kmb-grub.cfg.drv...
>> /gnu/store/2lnjrv5388727sw45jhrrsyf0140nrd2-system
>> /gnu/store/gsxap47dgsjs6zvdim42j5lal5rfj10w-grub.cfg
>>
>> activating system...
>> making '/gnu/store/2lnjrv5388727sw45jhrrsyf0140nrd2-system' the current 
>> system...
>> setting up setuid programs in '/run/setuid-programs'...
>> populating /etc from /gnu/store/hzhhbayyfxjqghxklawy8r8a1i8ws7pg-etc...
>> The following derivation will be built:
>>    /gnu/store/6wy32ybajjrdn1nydvp1i0iai6x77jqc-install-bootloader.scm.drv
>> building 
>> /gnu/store/6wy32ybajjrdn1nydvp1i0iai6x77jqc-install-bootloader.scm.drv...
>> guix system: bootloader successfully installed on '/dev/sda'
>> guix system: error: exception caught while executing 'eval' on service 
>> 'root':
>> Unrecognized keyword: #:file-creation-mask
>
> Can you post the output of 'guix describe' and the config.scm you are
> using?

I can reproduce the error when upgrading (i.e. guix pull and guix system
reconfigure) from commit 74c7f36 to commit aea6ab2.  I believe this will
always happen when upgrading from a commit before e3358a8
(gnu: shepherd: Update to 0.8.0.) to any commit starting from 4c0cc7b
(services: syslog: Simplify 'start' method.).

The latter commit changes the syslog-service-type to use a feature
introduced in version 0.8.0 of the Shepherd (the #:file-creation-mask
parameter of make-forkexec-constructor) so when Guix tries to load the
new service definition the current Shepherd (0.7.0) doesn't recognise
the new parameter and we get an error.

The error is harmless since this happens after switching the system
generation and installing the bootloader.  But we should probably print
a hint or warning, that some service definitions couldn't be loaded and
that it might be necessary to reboot, instead of an error so that it
doesn't look like reconfigure failed.

Regards,

Diego