bug#36876: guix system delete-generations removes custom boot menu entries

[Ludovic Courtès]

Hello,

address@hidden (Jakob L. Kreuze) skribis:

> Ludovic Courtès <address@hidden> writes:
>
>> I agree with Danny here that parsing the GRUB config wouldn’t be great.
>>
>> We have information about the user’s extra menu entries.  The issue, as
>> I see it, as that this information is lost once the system is
>> instantiated.
>>
>> But!  We have the <boot-parameters> structure, that gets serialized with
>> the system, and which we could extend with those extra menu entries.
>> That way, the info would be preserved, and we can restore them upon
>> ‘delete-generations’.  <menu-entry> records are bootloader-independent,
>> which is good.
>>
>> How does that sound?
>
> Would that involve appending an additional field to <boot-parameters>
> for storing the previous entries? I think that would have the pleasant
> side-effect of making the code for deployment/reconfiguration simpler :)

Oh that’d be nice.

The attached patches should fix this.  I’ve successfully deleted a
generation on my system. :-)  I don’t have extra menu entries though, so
it’d be great if you could give it a try.

Thanks,
Ludo’.

0001-system-Add-bootloader-menu-entries-field-to-boot-par.patch
Description: Text Data

0002-guix-system-Reinstalling-the-bootloader-preserves-ex.patch
Description: Text Data