[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#36084: ghc-tasty/ghc-clock circular dependency breaking is broken
From: |
Timothy Sample |
Subject: |
bug#36084: ghc-tasty/ghc-clock circular dependency breaking is broken |
Date: |
Tue, 16 Jul 2019 15:11:00 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Hi,
Robert Vollmert <address@hidden> writes:
>> On 16. Jul 2019, at 17:08, Timothy Sample <address@hidden> wrote:
>>
>> Hi Robert,
>>
>> After looking at this and your patch at <https://bugs.gnu.org/36249>,
>> I’m wondering if it works as long as we make sure the versions match.
>> Can we just inherit the current “ghc-clock”, disable its tests, and call
>> it “ghc-clock-bootstrap”? Is the Cabal consistency checking too clever
>> for that?
>>
>> If that doesn’t work, can you explain why the method you proposed above
>> doesn‘t work? It seems a little simpler than your patch. In fact,
>> maybe we could live with the main “ghc-tasty” package being built
>> without “ghc-clock” (via the flag you mentioned).
>
> I tried the direct approach again, and this time it worked. Posted an
> updated patch.
>
> I believe this should be fine, since GHCs builds should be deterministic.
It looks like this is a common idiom for us, so I’m pretty confident,
too. Fixed in 71e5d425c9b9e108ebdd06d13de45b56dddd9ef5. Thanks!
-- Tim