[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#25831: Expose http_proxy setting on GuixSD
From: |
Leo Famulari |
Subject: |
bug#25831: Expose http_proxy setting on GuixSD |
Date: |
Wed, 22 Feb 2017 14:22:23 -0500 |
User-agent: |
Mutt/1.7.2 (2016-11-26) |
On Wed, Feb 22, 2017 at 10:51:47AM +0100, Mathieu Lirzin wrote:
> I don't know much about HTTP proxying but when reading
> 'in-band-download' in "guix/download.scm" I see a line like this:
>
> #:leaked-env-vars '("http_proxy" "https_proxy")
>
> which makes me think that maybe we should add an https_proxy toggle in
> 'guix-configuration' too?
>
> However I see that 'open-connection-for-uri' in "guix/download.scm"
> ignores "https_proxy" with a comment from 2015:
>
> ;; For HTTPS URIs, honor 'https_proxy', not 'http_proxy'.
> ;; FIXME: Proxying is not supported for https.
That's from 'guix/build/download.scm'.
> Do you have any idea if this could be easily fixed?
I don't know. I guess that it would be required to have a TLS client
(gnutls-guile) and a certificate store available, but I'm not sure how
to implement it, or what exactly is missing.
> I think it would be more readable like this:
>
> #$@(if http-proxy
> (list (string-append "http_proxy=" http-proxy))
> '())
I think this form of the conditional is a little easier to read than the
other one, so I've used it in my updated patch, which is attached.
0001-services-guix-Support-using-an-HTTP-proxy.patch
Description: Text document
- bug#25831: Expose http_proxy setting on GuixSD, Leo Famulari, 2017/02/21
- bug#25831: Expose http_proxy setting on GuixSD, Mathieu Lirzin, 2017/02/21
- bug#25831: Expose http_proxy setting on GuixSD, Leo Famulari, 2017/02/21
- bug#25831: Expose http_proxy setting on GuixSD, Mathieu Lirzin, 2017/02/22
- bug#25831: Expose http_proxy setting on GuixSD,
Leo Famulari <=
- bug#25831: Expose http_proxy setting on GuixSD, Mathieu Lirzin, 2017/02/22
- bug#25831: Expose http_proxy setting on GuixSD, Leo Famulari, 2017/02/22
- bug#25831: Expose http_proxy setting on GuixSD, ng0, 2017/02/23
- bug#25831: Expose http_proxy setting on GuixSD, Leo Famulari, 2017/02/23
- bug#25831: Expose http_proxy setting on GuixSD, ng0, 2017/02/23