[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Inhibit duplicates in fold-packages
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH] Inhibit duplicates in fold-packages |
Date: |
Wed, 13 Feb 2013 22:35:37 +0100 |
User-agent: |
Gnus/5.130005 (Ma Gnus v0.5) Emacs/24.2 (gnu/linux) |
Mark H Weaver <address@hidden> skribis:
> Here's a patch to inhibit the same package (in the sense of eq?) from
> being traversed more than once by fold-packages. One example where this
> helps is the guile-2.0 package in (gnu packages guile), which is
> exported in two different variables: guile-2.0 and guile-2.0/fixed.
Looks good to me; can you update the docstring to mention that each
package is traversed only once? Then feel free to push.
BTW, I think ‘guile-2.0/fixed’ is the only case where this happens
actually, no?
BTW2, when doing non-trivial changes like this one, make sure to add a
copyright line under your name.
Thanks!
Ludo’.