[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#28590: [PATCH 1/7] weak-table: Fix unbounded growth of the disappear
From: |
Ludovic Courtès |
Subject: |
bug#28590: [PATCH 1/7] weak-table: Fix unbounded growth of the disappearing link table. |
Date: |
Tue, 3 Oct 2017 13:43:46 +0200 |
Partly fixes <https://bugs.gnu.org/28590>.
* libguile/weak-table.c (resize_table): Remove all disappearing links on
OLD_ENTRIES, and reset all of OLD_ENTRIES.
---
libguile/weak-table.c | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/libguile/weak-table.c b/libguile/weak-table.c
index 599c4cf0e..a0bebca5e 100644
--- a/libguile/weak-table.c
+++ b/libguile/weak-table.c
@@ -498,11 +498,19 @@ resize_table (scm_t_weak_table *table)
scm_t_weak_entry copy;
unsigned long new_k, distance;
+ /* Make sure we don't leave a disappearing link behind us.
+ See <https://github.com/ivmai/bdwgc/issues/182>. */
+ unregister_disappearing_links (&old_entries[old_k], table->kind);
+
if (!old_entries[old_k].hash)
- continue;
-
+ {
+ old_entries[old_k].key = old_entries[old_k].value = 0;
+ continue;
+ }
+
copy_weak_entry (&old_entries[old_k], ©);
-
+ old_entries[old_k].key = old_entries[old_k].value = 0;
+
if (!copy.key || !copy.value)
continue;
--
2.14.2
- bug#28590: [PATCH 0/7] Attempt to reduce memory growth, Ludovic Courtès, 2017/10/03
- bug#28590: [PATCH 6/7] weak-table: 'rob_from_rich' accounts for disappeared entries., Ludovic Courtès, 2017/10/03
- bug#28590: [PATCH 7/7] weak-table: Resize less frequently., Ludovic Courtès, 2017/10/03
- bug#28590: [PATCH 3/7] weak-table: Make sure 'move_disappearing_links' actually moves links., Ludovic Courtès, 2017/10/03
- bug#28590: [PATCH 2/7] weak-table: Stress the GC a little less when resizing., Ludovic Courtès, 2017/10/03
- bug#28590: [PATCH 1/7] weak-table: Fix unbounded growth of the disappearing link table.,
Ludovic Courtès <=
- bug#28590: [PATCH 5/7] weak-table: 'move_weak_entry' reports disappeared links., Ludovic Courtès, 2017/10/03
- bug#28590: [PATCH 4/7] weak-table: Always unregister previous links when inserting an entry., Ludovic Courtès, 2017/10/03
- bug#28590: [PATCH 0/7] Attempt to reduce memory growth, Ludovic Courtès, 2017/10/04