[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#12827: [PATCH] Tweak web modules, support relative URIs
From: |
Andy Wingo |
Subject: |
bug#12827: [PATCH] Tweak web modules, support relative URIs |
Date: |
Sun, 21 May 2017 14:05:41 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
On Tue 21 Jun 2016 15:22, address@hidden (Ludovic Courtès) writes:
> Andy Wingo <address@hidden> skribis:
>
>> I would like to apply this patch, to master at least. Any objections?
>> We need documentation for the new exports, is the only missing thing.
>
> On a quick glance that looks good. My only concern would be
> incompatibilities; for instance, the ‘content-location’ can now be an
> object that doesn’t pass ‘uri?’, IIUC. Not sure how much of a problem
> that is.
I have applied this patch with some modifications and added docs.
Notably, the behavior of uri? is unchanged relative to master (though
there's a deprecation note; see NEWS) and string->uri keeps its old
behavior of not throwing exceptions. I also removed the "absolute-uri?"
stuff because it was unused and it seems silly to reserve that useful
name in that way -- RFC 3986 defines "absolute uri" simply as being a
URI without a fragment. Weird definition.
Thank you for the patch, Daniel, and thanks to Ludo and Mark for working
through this bug.
Andy
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- bug#12827: [PATCH] Tweak web modules, support relative URIs,
Andy Wingo <=