[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#10623: [PATCH] Fixed unbound variables and unbound values
From: |
Noah Lavine |
Subject: |
bug#10623: [PATCH] Fixed unbound variables and unbound values |
Date: |
Sat, 19 May 2012 10:24:24 -0400 |
Hello,
This looks correct to me. It would be ideal if you could make the
patch with "git format-patch". That will let you write the log entry
for the change.
If you plan to make bigger changes to Guile, you'll need to assign
copyright for your changes to the FSF. Please see
http://www.gnu.org/licenses/why-assign.html for the reason why, but in
summary, that gives them more power to defend the license on the code.
If you're willing to, email address@hidden and tell them you'd like to
assign copyright for Guile.
Thanks,
Noah
On Tue, May 15, 2012 at 2:48 PM, Sjoerd van Leent <address@hidden> wrote:
> ---
> module/language/ecmascript/base.scm | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/module/language/ecmascript/base.scm
> b/module/language/ecmascript/base.scm
> index b244bec..6f5c65b 100644
> --- a/module/language/ecmascript/base.scm
> +++ b/module/language/ecmascript/base.scm
> @@ -92,7 +92,7 @@
> (pdel o (string->symbol p)))
>
> (define-method (has-property? (o <js-object>) p)
> - (if (hashq-get-handle (js-props o) v)
> + (if (hashq-get-handle (js-props o) p)
> #t
> (let ((proto (js-prototype o)))
> (if proto
> @@ -176,9 +176,9 @@
> ((boolean? x) (if x 1 0))
> ((null? x) 0)
> ((eq? x *undefined*) +nan.0)
> - ((is-a? x <js-object>) (object->number x))
> + ((is-a? x <js-object>) (object->number x #t))
> ((string? x) (string->number x))
> - (else (throw 'TypeError o '->number))))
> + (else (throw 'TypeError x '->number))))
>
> (define (->integer x)
> (let ((n (->number x)))
> --
> 1.7.5.4
>
>
>
>