[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#11262: help text fro sorted? predicate is wrong/misleading.
From: |
Ludovic Courtès |
Subject: |
bug#11262: help text fro sorted? predicate is wrong/misleading. |
Date: |
Sun, 22 Apr 2012 01:38:33 +0200 |
User-agent: |
Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.93 (gnu/linux) |
Hi Alexei,
(Removing Cc: guile-devel.)
Thanks for the patch!
Alexei Matveev <address@hidden> skribis:
> --- a/libguile/sort.c
> +++ b/libguile/sort.c
> @@ -101,9 +101,10 @@ SCM_DEFINE (scm_restricted_vector_sort_x,
> "restricted-vector-sort!", 4, 0, 0,
> * (not (less? (list-ref list i) (list-ref list (- i 1)))). */
> SCM_DEFINE (scm_sorted_p, "sorted?", 2, 0, 0,
> (SCM items, SCM less),
> - "Return @code{#t} iff @var{items} is a list or a vector such that\n"
> - "for all 1 <= i <= m, the predicate @var{less} returns true when\n"
> - "applied to all elements i - 1 and i")
> + "Return @code{#t} iff @var{items} is a list or a vector such\n"
> + "that for all 1 <= i <= m, the predicate @var{less} returns\n"
> + "@code{#f} when comparing element i to the preceeding element\n"
> + "i - 1.")
How about this:
Return @code{#t} iff @var{items} is a list or vector such that,
for each element @var{x} and the next element @var{y} of @var{items},
@code{(@var{less} @var{x} @var{y})} returns @code{#f}.
This avoids use of ‘m’, which would need to be defined, and makes it
clear what “comparing element i to the preceeding element” means.
What do you think?
Thanks,
Ludo’.
- bug#11262: help text fro sorted? predicate is wrong/misleading., Alexei Matveev, 2012/04/17
- bug#11262: help text fro sorted? predicate is wrong/misleading., Noah Lavine, 2012/04/18
- bug#11262: help text fro sorted? predicate is wrong/misleading., Alexei Matveev, 2012/04/20
- bug#11262: help text fro sorted? predicate is wrong/misleading.,
Ludovic Courtès <=
- bug#11262: help text fro sorted? predicate is wrong/misleading., Ian Hulin, 2012/04/22
- bug#11262: help text fro sorted? predicate is wrong/misleading., Ludovic Courtès, 2012/04/22
- bug#11262: help text fro sorted? predicate is wrong/misleading., Alexei Matveev, 2012/04/22
- bug#11262: help text fro sorted? predicate is wrong/misleading., Ludovic Courtès, 2012/04/22
- bug#11262: help text fro sorted? predicate is wrong/misleading., Marijn, 2012/04/26
- bug#11262: help text fro sorted? predicate is wrong/misleading., Noah Lavine, 2012/04/26