bug-guile
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] reader.test fix for cygwin


From: Neil Jerram
Subject: [PATCH] reader.test fix for cygwin
Date: Mon, 9 Jun 2008 20:13:09 +0100

On cygwin (with current 1.8.x branch code), there are two failures in
reader.test:

Running reader.test
ERROR: reader.test: mismatching parentheses: closing parenthesis
following mismatched opening - arguments: ((regular-expression-syntax
"make-regexp" "parentheses not balanced" #f ("unexpected \")\"$")))
ERROR: reader.test: mismatching parentheses: closing parenthesis
following mismatched vector opening - arguments:
((regular-expression-syntax "make-regexp" "parentheses not balanced"
#f ("unexpected \")\"$")))

These are fixed by the patch below - which I think is correct for all
platforms, because unescaped ( and ) perform grouping in Guile
regexps.  In these tests we want literal ( and ), so they should be
escaped.

(I guess it must be that non-cygwin regexp libraries are more
permissive about treating an unescaped ) as a literal when there is no
group to terminate.)

Any objections to committing this?

    Neil

diff --git a/test-suite/tests/reader.test b/test-suite/tests/reader.test
index 0b13cf1..f235ac1 100644
--- a/test-suite/tests/reader.test
+++ b/test-suite/tests/reader.test
@@ -24,7 +24,7 @@
 (define exception:eof
   (cons 'read-error "end of file$"))
 (define exception:unexpected-rparen
-  (cons 'read-error "unexpected \")\"$"))
+  (cons 'read-error "unexpected \"\\)\"$"))
 (define exception:unterminated-block-comment
   (cons 'read-error "unterminated `#! ... !#' comment$"))
 (define exception:unknown-character-name




reply via email to

[Prev in Thread] Current Thread [Next in Thread]