Re: gethost error display

[Rob Browning]

Kevin Ryde <address@hidden> writes:

> I don't know if the gethost error should be changed, it might break
> existing code to do so.
>
> But it might be nice if the default error handler was more forgiving
> of exception arguments.  If the arguments are pretty much arbitrary
> then perhaps some sort of heuristic like using simple-format only if
> there's the right number of ~A or ~S in the string.

Actually, I wonder if this is just a bug.  The scm_error call in
scm_resolv_error passes the bad host name as a format argument, but
none of the error messages have format escapes.  So I suspect maybe
this call:

      scm_error (key, subr, errmsg, scm_cons (bad_value, SCM_EOL), SCM_EOL);

should actually look like this:

      scm_error (key, subr, errmsg, SCM_BOOL_F, scm_list_1 (bad_value));

so that we pass the bad hostname as one of the exception extra data
items rather than making it the first format string item.

Anyone have any counterarguments?

-- 
Rob Browning
rlb @defaultvalue.org and @debian.org; previously @cs.utexas.edu
GPG starting 2002-11-03 = 14DD 432F AE39 534D B592  F9A0 25C8 D377 8C7E 73A4