Re: [Bug-gsl] Contribution: Hermite polynomials, functions etc.

[Konrad]

Hi Rhys,

thanks for your quick reply, I'll go through your points one by one.

> 1) We need a set of gsl_sf_hermite.h declarations.  Should this just
> be all non-static functions declared within your gsl_hermite.c file?
> Should the single-point functions like gsl_sf_hermite_prob and
> gsl_sf_hermite_prob_der be publicly exposed too?

Yes, all functions should be publicly exposed, since they all have a
direct use. I had already wondered why so many of the existing
GSL-functions are defined as static, but then without giving it much
thought I just re-defined mine the same way to make it similar. In
retrospect, that may have been pretty stupid... In the attached file
gsl_hermite.c all functions are defined non-static. Also, I have
attached the corresponding header file gsl_sf_hermite.h with a
declaration for each function. (It's really just gsl_sf_laguerre.h
adapted to my functions...)


> 2) We need to get the test cases in gsl_hermite_test.c using the GSL
> test infrastructure.  You can see an example of this within
> specfunc/test_airy.c.  I think getting the test code ported over
> should be relatively quick but I'm uncertain what tolerances to use
> given the printf statements in your gsl_hermite_test.c code.

OK, I'll take a look at the GSL test-framework and check my functions.
Might take a little while though.

> 3) We'll need to add documentation for the new functions.  These will
> resemble content like doc/specfunc-airy.texi.  Much of the necessary
> content appears in your email and can be written once we've got a
> gsl_sf_hermite.h in hand from item 1.

Same here, I'll try to write something, but that might not happen
immediately.

Is this the standard way of submitting stuff or should I go about it
differently from now on?

Cheers,
Konrad

gsl_hermite.c
Description: Text Data

gsl_sf_hermite.h
Description: Text Data