[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Bug-gsl] Deprecated variables in fft and wavelet modules
From: |
Alex Tartakovsky |
Subject: |
[Bug-gsl] Deprecated variables in fft and wavelet modules |
Date: |
Sun, 25 Sep 2005 18:33:12 -0700 (PDT) |
Enum variables 'forward' and 'backward' in fft and wavelet modules were
deprecated in version 1.6 (see the declarations in gsl_fft.h and
gsl_wavelet.h). However, the implementations in version 1.7 still use them.
As a result, if you #define GSL_DISABLE_DEPRECATED, the code will not compile.
The manual (p. 9, 2.13) states that this definition allows the code to be
tested for forward compatibility. In my understanding, that means that the
code should compile with both defined and undefined GSL_DISABLE_DEPRECATED.
All instances of forward and backward in fft should be replaced with
gsl_fft_forward and gsl_fft_backward respectively. Forward and backward in
wavelet module should be replaced with gsl_wavelet_forward and
gsl_wavelet_backward.
Global search and replace will do it easily; just in case, here are the
locations:
Fft forward - fft\dft_source.c(25), fft\c_main.c(29), fft\c_pass_2.c(50),
fft\c_pass_3.c(55), fft\c_pass_4.c(56), fft\c_pass_5.c(64), fft\c_pass_6.c(66),
fft\c_pass_7.c(74), fft\c_pass_n.c(185), fft\c_radix2.c(24),
fft\c_radix2.c(181);
fft backward - fft\dft_source.c(35), fft\c_main.c(42), fft\dft_source.c(46),
fft\c_main.c(55), fft\c_pass_n.c(100), fft\c_radix2.c(33), fft\c_radix2.c(42),
fft\c_radix2.c(191), fft\c_radix2.c(201).
Wavelet forward - wavelet\dwt.c(78), wavelet\dwt.c(135), wavelet\dwt.c(158),
wavelet\dwt.c(208), wavelet\dwt.c(262), wavelet\dwt.c(312), wavelet\dwt.c(343);
wavelet backward - wavelet\dwt.c(166), wavelet\dwt.c(322), wavelet\dwt.c(353).
Also, the manual states that deprecated functions will be removed from
subsequent versions. It's high time to remove gsl_sf_coupling_6j_INCORRECT_e
and gsl_sf_coupling_6j_INCORRECT that still persist since being deprecated in
version 1.5. This probably applies to 'forward' and 'backward' too.
Regards,
Alex Tartakovsky
---------------------------------
Yahoo! for Good
Click here to donate to the Hurricane Katrina relief effort.
- [Bug-gsl] Deprecated variables in fft and wavelet modules,
Alex Tartakovsky <=