[bug #61718] util/grub.d/30_os-prober.in: only print warning when os-prober is actually available

[Christoph Anton Mitterer]

URL:
  <https://savannah.gnu.org/bugs/?61718>

                 Summary: util/grub.d/30_os-prober.in: only print warning when
os-prober is actually available
                 Project: GNU GRUB
            Submitted by: calestyo
            Submitted on: Thu 23 Dec 2021 04:29:01 AM UTC
                Category: User Interface
                Severity: Major
                Priority: 5 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
                 Release: 
                 Release: Git master
         Discussion Lock: Any
         Reproducibility: Every Time
         Planned Release: None

    _______________________________________________________

Details:

Hey.

In util/grub.d/30_os-prober.in you have:

if [ "x${GRUB_DISABLE_OS_PROBER}" = "xtrue" ]; then
  grub_warn "$(gettext_printf "os-prober will not be executed to detect other
bootable partitions.\nSystems on them will not be added to the GRUB boot
configuration.\nCheck GRUB_DISABLE_OS_PROBER documentation entry.")"
  exit 0
fi


followed by:


if ! command -v os-prober > /dev/null || ! command -v linux-boot-prober >
/dev/null ; then
  # missing os-prober and/or linux-boot-prober
  exit 0
fi


why not switching the two, so that that annoying message is omitted, when the
system doesn’t have os-prober installed anyway?

I would make a pull request... but... where? ^^
So attached is a patch created by git format-patch.


Cheers,
Chris.




    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?61718>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/