[bug #45709] Grub git master makes bad grub.cfg with btrfs raid of lvm volumes

[James Harvey]

Follow-up Comment #4, bug #45709 (project grub):

Not a distribution specific bug.  Made a pure upstream git master build.

After grub-mkconfig -o /boot/grub/grub.cfg still includes:
=====
### BEGIN /etc/grub.d/10_linux ###
...
insmod part_gpt
insmod part_gpt
insmod part_gpt
insmod lvm
insmod lvm
insmod lvm
set
root='lvmid/VSnSKT-mFjn-H3fD-xC1o-eyCG-3a5S-rgNQy3/thnod1-e6Gy-O5Gl-8t6h-6zGv-zPjV-jG1
lvmid/4fRRgD-yA28-KKou-f2Uj-RhFP-nFBd-K7ysCV/DoXOeq-5RM2-OdZI-5Tt3-C41n-ROYj-eAT0bp
lvmid/uwsOsc-fegJ-RM3r-qASe-Ix0w-MiVx-BNqmeS/xie7dX-aAXH-Iet7-O8Bl-2sxU-82Am-hifghT'
...
echo    'Loading Linux linux ...'
linux   /original/boot/vmlinuz-linux root=/dev/mapper/disk1-terra1
/dev/mapper/disk2-terra2
/dev/mapper/disk3-terra3 ro rootflags=subvol=original
echo    'Loading initial ramdisk ...'
...
=====

/usr/bin/grub-mkconfig:261 executes /etc/grub.d/10_linux
/etc/grub.d/10_linux:125 executes:
prepare_boot_cache="$(prepare_grub_to_access_device ${GRUB_DEVICE_BOOT} |
grub_add_tab)"
/usr/bin/grub-mkconfig:139 set: GRUB_DEVICE_BOOT="`${grub_probe}
--target=device /boot`"
and # grub-prove --target=device /boot
/dev/mapper/disk1-terra1
/dev/mapper/disk2-terra2
/dev/mapper/disk3-terra3
{{{ where all it needs is the first one due to the way btrfs raids work - you
just specify one of the devices }}}
/usr/share/grub/grub-mkconfig_lib:132 then causes the triplicate insmod
part_gpt via "grub-probe --device /dev/mapper/disk1-terra1
/dev/mapper/disk2-terra2 /dev/mapper/disk3-terra3 --target=partmap"
:139 then causes the triplicate insmod lvm via "grub-probe --device
/dev/mapper/disk1-terra1 /dev/mapper/disk2-terra2 /dev/mapper/disk3-terra3
--target=abstraction"
:144 only makes a single insmod btrfs via "grub-probe --device
/dev/mapper/disk1-terra1 /dev/mapper/disk2-terra2 /dev/mapper/disk3-terra3
--target=fs"
{{{ grub-probe knows to output one unique line here, where the two before it
outputs three triplicate lines }}}
:157 then causes the set
root='lvmid/VSnSKT-mFjn-H3fD-xC1o-eyCG-3a5S-rgNQy3/thnod1-e6Gy-O5Gl-8t6h-6zGv-zPjV-jG1kUK
lvmid/4fRRgD-yA28-KKou-f2Uj-RhFP-nFBd-K7ysCV/DoXOeq-5RM2-OdZI-5Tt3-C41n-ROYj-eAT0bp
lvmid/uwsOsc-fegJ-RM3r-qASe-Ix0w-MiVx-BNqmeS/xie7dX-aAXH-Iet7-O8Bl-2sxU-82Am-hifghT'
... via "grub-probe --device /dev/mapper/disk1-terra1 /dev/mapper/disk2-terra2
/dev/mapper/disk3-terra3 --target=compatibility_hint"
/etc/grub.d/10_linux:134 executes: linux ${rel_dirname}/${basename}
root=${linux_root_device_thisversion} ro ${args}
... with :189 setting linux_root_device_thisversion="${LINUX_ROOT_DEVICE}"
... with :49 setting: LINUX_ROOT_DEVICE=${GRUB_DEVICE}
which is set by /usr/bin/grub-mkconfig:135 as `${grub_probe} --target=device
/`"
... which outputs 3 lines just as it did with /boot
causing newlines in the kernel parameter line, preventing boot

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?45709>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/