Re: Bug#268482: Please include reiser4 fs support

[Vitaly Fertman]

On Tuesday 21 September 2004 21:16, Robert Millan wrote:
> On Tue, Sep 21, 2004 at 11:55:24AM +0400, Vitaly Fertman wrote:
> > > >  - The patch modifies stage2/ufs2.h, which has nothing to do with
> > > > reiserfs. Your changes to ufs2.h look like portability improvements. 
> > > > Is that it?
> >
> > yes, there were some problems with compiling. Grub with reiser4 support
> > links to libreiser4 and libaal, to make it successfully compiled
> > --nostdinc option was eliminated and then ufs2 code started producing
> > redefinition errors. So I embraced such defines with ifndefs.
> > Would you prefere to solve it in another way?
>
> IMHO, linking with an external library sounds right but nuking -nostdinc
> for all the code doesn't.  I think that decision belongs to Okuji, the
> maintainer.

sure.

> Okuji, I got this patch [1] from Debian BTS.  The copyright header says it
> was written by Hans Reiser, but Hans says he didn't write it, and he hasn't
> assigned copyright either.
>
> Hans, if you know who wrote the patch please tell Okuji about it.  Thanks!

it was initially written by Yury Umanets. As he left Namesys I made later 
changes there according to changes in reiser4progs and the patch on 
        ftp://ftp.namesys.com/pub/reiser4progs/grub/ 
was prepared by me also.

-- 
Thanks,
Vitaly Fertman