bug-grub
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: go about releasing 0.93


From: Pavel Roskin
Subject: Re: go about releasing 0.93
Date: Mon, 2 Dec 2002 21:14:37 -0500 (EST)

Hello!

> Thanks for pointing that out. I completely forgot that problem.
>
> Anyway, I've checked in my own fix to the CVS right now. I tested it
> and it is even better than before, because you can see the cursor when
> you input a password.

I felt that the problem can be more fundamental.  It's great that you
fixed it the right way!

Everything is working fine now.  I had a chance to test Realtek 8139
driver and serial console - no problem.  I also could load kernel over
tftp.

The is a funny bug in the completion code when tftp is enabled:

grub> kernel (hd
 Possible disks are:  hd0 nd

grub> kernel (n
Error 23: Error while parsing number

I was pressing Tab while the cursor was on 'h' and 'n' respectively.  But
it's a very minor issue.  I don't want it to delay the release if it's
hard to fix.  Netboot support in print_completions() is clearly a hack.
You may want to add a FIXME there for now.

Another little bug is that long lines are cut too early in the menu.  For
example, I press 'e' in the menu twice to edit the command and put a long
pattern from numbers.  That's what I see after I press Enter:

 +-------------------------------------------------------------------------+
 | 12345678901234567890123456789012345678901234567890123456789012345678    |
 |                                                                         |

I found function print_entry(), where it's implemented, and it seems to be
intentional.  Anyway, you should know better if it's a bug or not.

The right solution would be to show an arrow if the entry doesn't fit.

-- 
Regards,
Pavel Roskin




reply via email to

[Prev in Thread] Current Thread [Next in Thread]