Bug#74740: marked as done (grub-install doesn't work when using devfs)

[Debian Bug Tracking System]

Your message dated 20 Oct 2000 22:07:09 -0600
with message-id <address@hidden>
and subject line Fixed in grub 0.5.96.1
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Darren Benham
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 14 Oct 2000 13:57:59 +0000
>From address@hidden Sat Oct 14 08:57:59 2000
Return-path: <address@hidden>
Received: from www1.experteam.de [::ffff:195.138.53.252] 
        by master.debian.org with esmtp (Exim 3.12 1 (Debian))
        id 13kRp0-0005Qm-00; Sat, 14 Oct 2000 08:57:58 -0500
Received: from m-kombi.ExperTeam.de (m-kombi.experteam.de [192.168.5.1])
        by www1.ExperTeam.de (8.9.1/8.9.3) with SMTP id OAA10172
        for <address@hidden>; Sat, 14 Oct 2000 14:59:29 +0200
Received: from ExperTeam.de ([192.168.5.52]) by m-kombi.ExperTeam.de (Lotus 
SMTP MTA v4.6.2  (693.3 8-11-1998)) with SMTP id C1256978.004D78F4; Sat, 14 Oct 
2000 16:06:12 +0200
Sender: address@hidden
Message-ID: <address@hidden>
Date: Sat, 14 Oct 2000 15:37:46 +0200
From: Roderich Schupp <address@hidden>
Organization: ExperTeam AG
X-Mailer: Mozilla 4.75 [en] (X11; U; Linux 2.4.0-test10 i586)
X-Accept-Language: en
MIME-Version: 1.0
To: address@hidden
Subject: grub-install doesn't work when using devfs
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Delivered-To: address@hidden

Package: grub
Version: 0.5.96

grub-install doesn't work on a Linux kernel with devfs enabled if you
use
the "native" devfs device names (in /etc/fstab etc). Reasons:
- incorrect parsing of output of "df" (assumes that the device namespace
  is flat below /dev)
- incorrect extraction of device name for whole disk and partition
number
  from partition's device name.
See below for a fix.

Background:
devfs uses names like "/dev/scsi/host0/bus0/target10/lun0/part2" for
partitions (similar for IDE disks) and
"/dev/scsi/host0/bus0/target10/lun0/disc"
for the corresponding whole disk.

Cheers, Roderich

--- ORIG/util/grub-install.in   Sat Sep 30 03:35:21 2000
+++ ./util/grub-install.in      Sat Oct 14 14:01:45 2000
@@ -73,8 +73,10 @@
     # Break the device name into the disk part and the partition part.
     case "$host_os" in
     linux*)
-       tmp_disk=`echo "$1" | sed 's%\([sh]d[a-z]\)[0-9]*$%\1%'`
-       tmp_part=`echo "$1" | sed "s%$tmp_disk%%"` ;;
+       tmp_disk=`echo "$1" | sed -e 's%\(/[sh]d[a-z]\)[0-9]*$%\1%'
+                                 -e 's%/part[0-9]*$%/disc%'`
+       tmp_part=`echo "$1" | sed -e 's%.*/[sh]d[a-z]\([0-9]*\)$%\1%'
+                                 -e
's%.*/\(disc\|part\([0-9]*\)\)$%\2%'` ;;
     gnu*)
        tmp_disk=`echo "$1" | sed 's%\([sh]d[0-9]*\).*%\1%'`
        tmp_part=`echo "$1" | sed "s%$tmp_disk%%"` ;;
@@ -232,9 +234,9 @@
 # For now, this uses the program `df' to get the device name, but is
 # this really portable?
 root_device=`df ${rootdir}/ | grep /dev/ \
-    | sed 's%.*\(/dev/[a-z0-9]*\).*%\1%'`
+    | sed 's%.*\(/dev/[a-z0-9/]*\).*%\1%'`
 bootdir_device=`df ${bootdir} | grep /dev/ \
-    | sed 's%.*\(/dev/[a-z0-9]*\).*%\1%'`
+    | sed 's%.*\(/dev/[a-z0-9/]*\).*%\1%'`
 
 # Check if the boot directory is in the same device as the root
directory.
@@ -252,7 +254,7 @@
 # Check if the root directory exists in the same device as the grub
 # directory.
 grubdir_device=`df ${grubdir} | grep /dev/ \
-    | sed 's%.*\(/dev/[a-z0-9]*\).*%\1%'`
+    | sed 's%.*\(/dev/[a-z0-9/]*\).*%\1%'`
 if test "x$grubdir_device" != "x$root_device"; then
     # For now, cannot deal with this situation.
     cat <<EOF 1>&2

---------------------------------------
Received: (at 74740-done) by bugs.debian.org; 21 Oct 2000 04:08:10 +0000
>From address@hidden Fri Oct 20 23:08:10 2000
Return-path: <address@hidden>
Received: from static204-83-206-163.reverse.accesscomm.ca (trick.fig.org) 
[::ffff:204.83.206.163] 
        by master.debian.org with esmtp (Exim 3.12 1 (Debian))
        id 13mpx4-00046g-00; Fri, 20 Oct 2000 23:08:10 -0500
Received: from ip216-174-145-19.evenfaster.accesscomm.ca (faust.fig.org) 
[216.174.145.19] 
        by trick.fig.org with esmtp (Exim 2.05 #1 (Debian))
        id 13mpwy-0007I0-00; Fri, 20 Oct 2000 22:08:04 -0600
Received: from gord by faust.fig.org with local (Exim 3.12 #1 (Debian))
        id 13mpw5-00012L-00; Fri, 20 Oct 2000 22:07:09 -0600
To: address@hidden, address@hidden,
        address@hidden
Subject: Fixed in grub 0.5.96.1
X-Attribution:  Gord
From: Gordon Matzigkeit <address@hidden>
Date: 20 Oct 2000 22:07:09 -0600
Message-ID: <address@hidden>
Lines: 4
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Delivered-To: address@hidden


-- 
 Gordon Matzigkeit <address@hidden>  //\ I'm a FIG (http://fig.org/)
Committed to freedom and diversity \// I use GNU (http://www.gnu.org/)