[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] setkey fails and causes GRUB to crash.
From: |
OKUJI Yoshinori |
Subject: |
Re: [PATCH] setkey fails and causes GRUB to crash. |
Date: |
Tue, 10 Oct 2000 01:02:17 +0900 |
From: Daniel Pittman <address@hidden>
Subject: [PATCH] setkey fails and causes GRUB to crash.
Date: 09 Oct 2000 23:34:17 +1100
> It seems that no one must have tried to use the 'setkey' command in GRUB
> before today.
Be not so ironic. Such a statement could make your image bad.
> Code inspection says that the issue would be present at that time also.
> The attached patch is a fairly trivial change to the effected routine to
> make it test for a NULL pointer before doing the strcmp.
Thanks. I'll apply your patch.
> [1] Would there be interest in having this contributed back to GRUB
> when I have it - or the script to turn a Linux keymap into a GRUB
> keymap?
Of course. My plan is to bundle keymap translation files with GRUB,
so that the user can include one of them in his/her configuration file
by the command "include" (which is not implemented yet).
Okuji