[bug #62455] [PATCH] tmac/an.tmac: fix the "an-extra3" algorithm when the fifth argument to 'TH' is empty

[G. Branden Robinson]

Update of bug #62455 (project groff):

                  Status:                    None => Need Info              
             Assigned to:                    None => gbranden               

    _______________________________________________________

Follow-up Comment #1:

I don't find this report very helpful.

Please simply include the diagnostic output, or incorrect formatting, of the
man page in question.

The patch has spurious comments and rationale.  *roff does not have a Boolean
data type.  Please review the section/node "Numeric Expressions" of our
Texinfo manual for an explanation of truth values in the language.

https://git.savannah.gnu.org/cgit/groff.git/tree/doc/groff.texi#n5600

Further, the existing code in the 'TH' macro definition of tmac/an.tmac does
not use the '&' operator at all, anywhere; the commit message and comments in
the patch seem to suggest that it was employing it incorrectly, when this is
not the case.

https://git.savannah.gnu.org/cgit/groff.git/tree/tmac/an.tmac#n199

As a rule of thumb, it is a good practice to present the underlying problem in
a defect report with at least much detail as a proposed patch, because an
alternative solution might be a better one.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?62455>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/