bug-groff
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug #59817] [PATCH] src/roff/troff/input.cpp: Flatten .ec parser


From: G. Branden Robinson
Subject: [bug #59817] [PATCH] src/roff/troff/input.cpp: Flatten .ec parser
Date: Tue, 30 Mar 2021 23:49:38 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0

Follow-up Comment #4, bug #59817 (project groff):

[comment #3 comment #3:]
> [comment #2 comment #2:]
> > A comment explicitly tying this function to the user-level .ec
> > request would be illuminating to someone coming to this snippet cold.
> 
> I may have to retract this.  Looking at the rest of the file, it seems
init_input_requests() rather clearly associates roff-language requests with
input.cpp functions.

Agreed.  I have frequently visited that function in my travels through the
source. :D

Again I'll say, "[m]ore helpful I think would simply be a comment above the
function giving it a specification."



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?59817>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]