[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug #44018] [PATCH] gtroff hangs in environment::possibly_break_line wi
From: |
G. Branden Robinson |
Subject: |
[bug #44018] [PATCH] gtroff hangs in environment::possibly_break_line with -mja |
Date: |
Wed, 21 Oct 2020 03:07:51 -0400 (EDT) |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 |
Update of bug #44018 (project groff):
Severity: 3 - Normal => 4 - Important
Status: None => Fixed
Assigned to: None => gbranden
Open/Closed: Open => Closed
Planned Release: None => 1.23
_______________________________________________________
Follow-up Comment #1:
If we had better CJK support, this would've been a severity 5 - blocker.
Pretty bad to just hang forever.
Also pretty bad to take almost 6 years to fix an infinite loop. :-/
commit bcdf2f4c7c28328c711c6a7ac2ea17f2ecd5cdd4
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date: Wed Oct 21 00:29:24 2020 +1100
src/roff/troff/env.cpp: Avoid infinite loop.
* src/roff/troff/env.cpp (environment::possibly_break_line): Emit break
warning and return if the output width is not positive. The code
assumes that it will be and loops infinitely if it isn't. I _think_
this is because we're not able to get width data for (some?) CJK
glyphs. Based on a patch by Osamu Sayama.
Fixes <https://savannah.gnu.org/bugs/index.php?44018>.
commit 7964eb52debd3f09ce9125ca063c742448854fa8
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date: Wed Oct 21 00:39:39 2020 +1100
Add regression test for Savannah #44018.
Warning: "make check" will loop infinitely at this commit.
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?44018>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/