[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Bug-gnupod] new branches
From: |
H. Langos |
Subject: |
[Bug-gnupod] new branches |
Date: |
Wed, 24 Jun 2009 22:58:21 +0200 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
Hi Richard,
I see that you got your branches up into the central repository.
Here's some suggestions for how to proceed.
I guess the do_not_stretch_artwork feature is harmless. I'll merge
that into master.
The decrement_plid feature would be nice to include into master but
I don't know how iTunes or other software would react to such high
sequence numbers ... especially software that doesn't realy care if
a 32 bit integer is signed or unsigned...
How about this change:
Instead of decrementing from MAXINT, I would suggest to make the sequence
counter jump to the next 2^n value before the playlists are added?
This would not rise the values too high and still in most cases it would
avoid the massive shifting of IDs.
filename_in_desc and append_info_to_title I'll leave to you .. I guess you
could merge those and delete one of those branches .. those features will
probably not make it into master anyway. and if they do we can still
cherry-pick the commits.
cheers
-henrik
- [Bug-gnupod] new branches,
H. Langos <=