Re: [Bug-gnupod] mktunes.pl creates corrupt iTunesDB ?

[Richard van den Berg]

On Fri, June 12, 2009 15:21, Heinrich Langos wrote:
> I'd like to have a chain like this:  ok -> ok -> broken

Here is such a chain:

http://richard.vdberg.org/gnupod/ok/11181/iTunesDB
http://richard.vdberg.org/gnupod/ok/11182/iTunesDB
http://richard.vdberg.org/gnupod/ok/11183/iTunesDB
http://richard.vdberg.org/gnupod/not_ok/11184/iTunesDB

> Does this file have anything in its attributes that the files that you
> added successfully (until #11531) did not have? artwork maybe?

Nope. In fact it breaks in the middle of an album. All those songs had
been added with the same gnupod_addsong.pl --artwork run.

> Could you try to add the SAME file over and over until you get a non
> working state? That would make hunt for an overflow in the internal
> structures even easier. (gnupod_addsong "-d" allow duplicates).

I can do so tonight, but I was rather hoping of finding this bug without
having to wipe my iPod. Can't I just create a fake GNUtunesDB.xml with the
same file over and over again? I don't have the space left to add another
11000 actual songs to my iPod (unless it's 1 kb or smaller). In my testing
so far I've just been manually editing GNUtunesDB.xml and running
mktunes.pl to generate a new iTunesDB.

> Best way to get there is a binary search.

That's exactly what I used last night. :-) 15 iterations for 30000 files
is the best you can do.

> Did you try adding your collection with gtkpod? I assume it will be much
> faster as it is not written in perl.

Nope. I really don't need a GUI and yet another local database to keep
track off. I want gnupod! :-)

> I guess you add your collection album (directory) wise? So one
> gnupod_addsong process for each directory?

Yep. I need to because gnupod_addsong does not support different artwork
for different albums otherwise. I wrote a wrapper around gnupod_addsong to
set the right --artwork and --compilation options automagically.

> I suspect that most of the time will still be spent in
> GNUpod::XMLhelper::mkfile and GNUpod::XMLhelper::xescaped

I think so too. The wait for loading the XML was 30 seconds with 10000
files, and grew to 2 minutes with 30000 songs after a pod2tunes (create a
lot more XML attributes).

I'll do the profiling tonight.

Thanks for you input.

Cheers,

Richard