Re: [PATCH] lib/xstrtol.c: Fix xstrtol() on EINVAL (invalid base)

[Paul Eggert]

On 2024-07-25 02:27, Alejandro Colomar wrote:
> -  tmp = 1;
>
>         We will multiply the base by 1, even if it wasn't in the string.

I don't see that. There's no multiplication of BASE by 1 in "tmp = 1;".


> I don't understand too much the rest of xstrtol(), but I think it will
> successfully parse 1000, when it should have failed.

There's no reason xstrtol should fail in that situation.

Again, this is just a tempest in a teapot; real code doesn't run into 
this situation.