Re: [PATCH] getusershell: Work around musl bugs.

[Collin Funk]

On 5/19/24 7:17 PM, Bruno Haible wrote:
> You don't need an Alpine Linux machine to debug this. You can debug it
> on a glibc system like this:
>   1. create a testdir for the module getusershell,
>   2. configure through
>        ac_cv_func_getusershell=no ./configure
>   3. use the unit test, or compile a test program with -Itestdir/gllib
>      -Itestdir and link it with testdir/gllib/libgnu.a.

Ah, I forgot about this thanks.

It looks like the current code wants drive-prefixes accepted, i.e.
'c:/ugly/windows/stuff'.

That sort of breaks the behavior of glibc and BSD where:

     input -> getusershell () output
     'bin/bash' -> '/bash'

Since it seems silly to accept some drive prefix in the middle of a
string.

I can't imagine anyone putting non-absolute file names in that file.
So I'll probably restrict it to one absolute file name per-line and
then trim any leading whitespace plus comments. Perhaps getline and
filename.h macros will help there.

Collin