dup3: Update documentation and expected test results.

[Collin Funk]

Hi Bruno,

On 5/18/24 5:03 PM, Bruno Haible wrote:
>> Until then, maybe this should be added to the documentation? You
>> tested NetBSD 9.0 and NetBSD 10.0 and I reproduced on NetBSD 10.0.
>> From what I can tell from a brief look at the git history (don't know
>> how to use cvs, so github mirror) the behavior hasn't changed since it
>> was introduced in NetBSD 6.0.
> 
> For our doc's purposes, the moment when the bug has been introduced in
> NetBSD is not relevant. What we document is the newest version in which
> we could reproduce the bug. Please document it!

Ah, okay that makes sense. I misunderstood the version numbers. I was
under the impression that they were when the bug was introduced.

I guess that would be a full-time job itself to maintain. And there
isn't much benefit to documenting every bug in EOL operating systems
anyways.

> And it's a good idea to reference the bug report in a comment:
> @c https://gnats.netbsd.org/cgi-bin/query-pr-single.pl?number=58266
> So that in the future it helps us to understand what the bug is
> about and how to reproduce it in newer versions of NetBSD.
> 
> Also, you can now revert the latest commit of modules/dup3-tests.

Added documentation and removed the xfail stuff in the attached patch.
Very small so I figured a single commit is fine. On my NetBSD 10.0 VM
running:

  $ gnulib-tool --create-testdir --dir testdir1 dup3
  $ cd testdir1
  $ make check

and everything passes.

> Thanks again!

No worries. Thank you for explaining all the doc/*, lib/*, and test/*
conventions to me. Now that gnulib-tool.py is working, outside of a
few minor bugs (e.g. gl_DOC_BASE issue in gnulib-tool.py.TODO), I can
help investigate bugs and make improvements elsewhere too.

Collin

0001-dup3-Update-documentation-and-expected-test-results.patch
Description: Text Data