Re: gnulib-tool (Python) bug: "module count-one-bits doesn't exist"

[Collin Funk]

On 5/11/24 12:26 PM, Paul Eggert wrote:
> To reproduce it in a Gnulib repository, run these commands:
> 
> git checkout 4de6323d5d20996e51097a90f617cd4404a23eba
> ./gnulib-tool --create-testdir --dir foo -h stdbit
> 
> The failing output is as follows. I get this output on Fedora 40 x86-64.
> 
> gnulib-tool: warning: module count-leading-zeros     doesn't exist
> gnulib-tool: warning: module count-trailing-zeros     doesn't exist
> gnulib-tool: warning: module count-one-bits         doesn't exist
> Traceback (most recent call last):
>   File "/home/eggert/src/gnu/gnulib/./.gnulib-tool.py", line 30, in <module>
>     main.main_with_exception_handling()
>   File "/home/eggert/src/gnu/gnulib/pygnulib/main.py", line 1371, in

I've applied the attached patch to fix this crash. Since
Glmodulesystem.find() prints a warning/error message upon looking up a
non-existent module returning, returning None here and crashing is
incorrect.

With the module description from that patch and this gnulib-tool fix:


$ gnulib-tool --create-testdir --dir foo -h stdbit
gnulib-tool: warning: module count-leading-zeros         doesn't exist
gnulib-tool: warning: module count-trailing-zeros        doesn't exist
gnulib-tool: warning: module count-one-bits              doesn't exist
Module list with included dependencies (indented):
    absolute-header
    alignasof
    alignasof-tests


And just to confirm that the issue you were running into was due to
the tabs, I added quotes around the module name:


$ gnulib-tool --create-testdir --dir foo -h stdbit
gnulib-tool: warning: module 'count-leading-zeros       ' doesn't exist
gnulib-tool: warning: module 'count-trailing-zeros      ' doesn't exist
gnulib-tool: warning: module 'count-one-bits            ' doesn't exist
Module list with included dependencies (indented):
    absolute-header
    alignasof
    alignasof-tests
    assert-h


I'm not sure why gnulib-tool.sh handles the tabs correctly to be
honest...

Collin

0001-gnulib-tool.py-Filter-out-dependencies-that-cannot-b.patch
Description: Text Data